Remove pinned channel items customization from the demo#6340
Remove pinned channel items customization from the demo#6340VelikovPetar merged 4 commits intov7from
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request removes pinned channel visual styling logic from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
...ain/java/io/getstream/chat/android/compose/sample/ui/component/CustomChatComponentFactory.kt
Show resolved
Hide resolved
andremion
left a comment
There was a problem hiding this comment.
As I understood from https://getstream.slack.com/archives/C0A3JU6C6G3/p1775651311234899?thread_ts=1775568258.825169&cid=C0A3JU6C6G3, we should hide the pin option in the SDK.
Yeah, it's disabled by default in |
Oh, I'm seeing in the sample. Shouldn't we disable in the sample too? |
Yeah, it makes sense |
89ccea3 to
c82232f
Compare
|



Goal
Removing the custom background for pinned channels. We'll revisit it after the state is designed and bring it to the SDK.
Implementation
Remove the background modifier.
🎨 UI Changes
Pinned channels now look visually identical to regular ones
Testing
Launch the compose sample, pin a channel and verify that the corresponding channel item looks identical.
Summary by CodeRabbit