Skip to content

Remove pinned channel items customization from the demo#6340

Merged
VelikovPetar merged 4 commits intov7from
rm-pinned-channel-design
Apr 8, 2026
Merged

Remove pinned channel items customization from the demo#6340
VelikovPetar merged 4 commits intov7from
rm-pinned-channel-design

Conversation

@gpunto
Copy link
Copy Markdown
Contributor

@gpunto gpunto commented Apr 8, 2026

Goal

Removing the custom background for pinned channels. We'll revisit it after the state is designed and bring it to the SDK.

Implementation

Remove the background modifier.

🎨 UI Changes

Pinned channels now look visually identical to regular ones

Testing

Launch the compose sample, pin a channel and verify that the corresponding channel item looks identical.

Summary by CodeRabbit

  • Style
    • Removed visual styling previously applied to pinned channels.

@gpunto gpunto added the pr:demo-app Changes specific to demo app label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.82 MB 0.57 MB 🔴
stream-chat-android-ui-components 10.60 MB 10.95 MB 0.36 MB 🟡
stream-chat-android-compose 12.81 MB 12.25 MB -0.56 MB 🚀

@gpunto gpunto marked this pull request as ready for review April 8, 2026 14:11
@gpunto gpunto requested a review from a team as a code owner April 8, 2026 14:11
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 049ec546-1d20-4eb7-80b3-cc745340ec27

📥 Commits

Reviewing files that changed from the base of the PR and between ec339bf and 89ccea3.

📒 Files selected for processing (1)
  • stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/component/CustomChatComponentFactory.kt

Walkthrough

The pull request removes pinned channel visual styling logic from CustomChatComponentFactory. Previously, the code conditionally applied a background modifier based on channel pin status; the updated implementation removes this logic and consistently passes only Modifier.animateItem() to the ChannelItem component, eliminating unused imports.

Changes

Cohort / File(s) Summary
Pinned Channel Styling Removal
stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/component/CustomChatComponentFactory.kt
Removed conditional pinned background modifier application logic; now always passes only Modifier.animateItem() to ChannelItem. Cleaned up associated imports (background and isPinned).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Modifiers simplified, the styling removed,
No more pinned backgrounds in the mood,
Just animate and flow so free,
Code now cleaner as can be! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing pinned channel customization from the demo app.
Description check ✅ Passed The description covers Goal, Implementation, UI Changes, and Testing sections but omits several template sections like Contributor Checklist and comparison screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rm-pinned-channel-design

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@andremion andremion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpunto
Copy link
Copy Markdown
Contributor Author

gpunto commented Apr 8, 2026

As I understood from https://getstream.slack.com/archives/C0A3JU6C6G3/p1775651311234899?thread_ts=1775568258.825169&cid=C0A3JU6C6G3, we should hide the pin option in the SDK.

Yeah, it's disabled by default in ChannelOptionItemVisibility

@andremion
Copy link
Copy Markdown
Contributor

As I understood from https://getstream.slack.com/archives/C0A3JU6C6G3/p1775651311234899?thread_ts=1775568258.825169&cid=C0A3JU6C6G3, we should hide the pin option in the SDK.

Yeah, it's disabled by default in ChannelOptionItemVisibility

Oh, I'm seeing in the sample. Shouldn't we disable in the sample too?

@gpunto
Copy link
Copy Markdown
Contributor Author

gpunto commented Apr 8, 2026

As I understood from https://getstream.slack.com/archives/C0A3JU6C6G3/p1775651311234899?thread_ts=1775568258.825169&cid=C0A3JU6C6G3, we should hide the pin option in the SDK.

Yeah, it's disabled by default in ChannelOptionItemVisibility

Oh, I'm seeing in the sample. Shouldn't we disable in the sample too?

Yeah, it makes sense

@gpunto gpunto force-pushed the rm-pinned-channel-design branch from 89ccea3 to c82232f Compare April 8, 2026 14:35
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@VelikovPetar VelikovPetar merged commit 77a4a20 into v7 Apr 8, 2026
15 checks passed
@VelikovPetar VelikovPetar deleted the rm-pinned-channel-design branch April 8, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:demo-app Changes specific to demo app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants