Skip to content

Fix paddings in group channel info screens#6350

Merged
andremion merged 1 commit intov7from
bug/fix_group_channel_info_paddings
Apr 9, 2026
Merged

Fix paddings in group channel info screens#6350
andremion merged 1 commit intov7from
bug/fix_group_channel_info_paddings

Conversation

@VelikovPetar
Copy link
Copy Markdown
Contributor

@VelikovPetar VelikovPetar commented Apr 9, 2026

Goal

Fix incorrect paddings in the group channel info, edit, and add members screens to match the Figma design specs.

Implementation

  • AddMembersScreen: Removed unnecessary top padding from the members list LazyColumn content padding.
  • GroupChannelEditScreen: Added end padding (spacingSm) to the Save button in the top bar.
  • GroupChannelInfoScreen: Added end padding (spacingSm) to the Edit button in the top bar.

UI Changes

Updated snapshot tests reflect the padding corrections.

Testing

  • Verified via updated snapshot tests for AddMembersScreen, GroupChannelEditScreen, and GroupChannelInfoContent.

Summary by CodeRabbit

  • Style
    • Refined padding and spacing consistency across channel management screens, including adjustment of member list layout and alignment of action buttons in edit and info screens.

Co-Authored-By: Claude <noreply@anthropic.com>
@VelikovPetar VelikovPetar added the pr:bug Bug fix label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@VelikovPetar VelikovPetar marked this pull request as ready for review April 9, 2026 12:36
@VelikovPetar VelikovPetar requested a review from a team as a code owner April 9, 2026 12:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 79807494-ad95-4f14-8f82-2505e99b455e

📥 Commits

Reviewing files that changed from the base of the PR and between 1e20c6f and 4beefe6.

⛔ Files ignored due to path filters (14)
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_loading_more.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_loading_more_in_dark_mode.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results_in_dark_mode.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results_with_existing_member.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results_with_existing_member_in_dark_mode.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results_with_query.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results_with_query_in_dark_mode.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results_with_selection.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_AddMembersScreenTest_results_with_selection_in_dark_mode.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_GroupChannelEditScreenTest_filled.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_GroupChannelEditScreenTest_placeholder.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_GroupChannelInfoContentTest_collapsed_members.png is excluded by !**/*.png
  • stream-chat-android-compose/src/test/snapshots/images/io.getstream.chat.android.compose.ui.channel.info_GroupChannelInfoContentTest_collapsed_members_in_dark_mode.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/AddMembersScreen.kt
  • stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/GroupChannelEditScreen.kt
  • stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/GroupChannelInfoScreen.kt

Walkthrough

These changes adjust padding and spacing in channel info UI components across three screens. AddMembersScreen removes top padding from its content layout, while GroupChannelEditScreen and GroupChannelInfoScreen add explicit end padding to buttons for consistency.

Changes

Cohort / File(s) Summary
Channel Info Padding Adjustments
AddMembersScreen.kt, GroupChannelEditScreen.kt, GroupChannelInfoScreen.kt
Simplified and added explicit padding to UI elements. AddMembersScreen removes top padding from LazyColumn, while GroupChannelEditScreen and GroupChannelInfoScreen add end padding to buttons for layout consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops of spacing, aligned with grace,
Padding tweaks in every place,
Buttons nestled, snug and neat,
UI harmony, oh what a treat!
More whitespace makes it all complete!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing padding issues in group channel info screens, which directly aligns with the changeset modifications.
Description check ✅ Passed The description includes Goal, Implementation, UI Changes, and Testing sections as required by the template. However, it lacks before/after screenshots, videos, and the complete contributor checklist items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/fix_group_channel_info_paddings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.82 MB 0.57 MB 🔴
stream-chat-android-ui-components 10.60 MB 10.96 MB 0.36 MB 🟡
stream-chat-android-compose 12.81 MB 12.25 MB -0.56 MB 🚀

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

@andremion andremion enabled auto-merge (squash) April 9, 2026 13:16
@andremion andremion merged commit 4008e90 into v7 Apr 9, 2026
16 of 17 checks passed
@andremion andremion deleted the bug/fix_group_channel_info_paddings branch April 9, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants