Skip to content

Set required permissions for the SDK size and DB entities checks#6398

Merged
gpunto merged 2 commits intodevelopfrom
sdk-size-checks-permissions
Apr 29, 2026
Merged

Set required permissions for the SDK size and DB entities checks#6398
gpunto merged 2 commits intodevelopfrom
sdk-size-checks-permissions

Conversation

@gpunto
Copy link
Copy Markdown
Contributor

@gpunto gpunto commented Apr 29, 2026

Goal

SDK size & DB entities checks need write permissions for writing comments, so we're adding the relevant permission block. Up until now, this didn't cause problems because the token we're using has those permissions, but that doesn't work for Dependabot PRs. They receive a read-only token unless we declare permissions, which is why the corresponding failures in #6394.

Implementation

Add the permissions block

Testing

After merging this PR, we should update dependabot's PR and verify that the SDK size check succeeds

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow permissions to explicitly define authorization scopes for continuous integration checks and SDK size verification tasks.

@gpunto gpunto added the pr:ci CI changes label Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Copy Markdown
Contributor

DB Entities have been updated. Do we need to upgrade DB Version?
Modified Entities :

.github/workflows/check-entities.yml

@gpunto gpunto marked this pull request as ready for review April 29, 2026 14:59
@gpunto gpunto requested a review from a team as a code owner April 29, 2026 14:59
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9b6042af-95c4-4902-b1fc-7de537185002

📥 Commits

Reviewing files that changed from the base of the PR and between d76ee9f and 890f721.

📒 Files selected for processing (2)
  • .github/workflows/check-entities.yml
  • .github/workflows/sdk-size-checks.yml

Walkthrough

Two GitHub Actions workflows now explicitly declare permissions for the default token, specifying read access to repository contents and write access to pull requests and issues, rather than relying on implicit defaults.

Changes

Cohort / File(s) Summary
Workflow Permissions
.github/workflows/check-entities.yml, .github/workflows/sdk-size-checks.yml
Added explicit top-level permissions declarations with contents: read, pull-requests: write, and issues: write scopes to both workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Permission slips in pockets snug,
No longer default's vague hug,
Token scopes declared with care,
Security whispered through the air!
Two workflows now stand proud and bright,

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding required permissions to two GitHub Actions workflows for SDK size and DB entities checks.
Description check ✅ Passed The description covers Goal and Implementation sections with clear rationale and context, but lacks Testing section details, UI Changes section (expected as not applicable), and contributor checklist completion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sdk-size-checks-permissions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.82 MB 5.82 MB 0.00 MB 🟢
stream-chat-android-ui-components 11.02 MB 11.02 MB 0.00 MB 🟢
stream-chat-android-compose 12.35 MB 12.35 MB 0.00 MB 🟢

@gpunto gpunto enabled auto-merge (squash) April 29, 2026 15:02
Comment thread .github/workflows/check-entities.yml Outdated
Comment thread .github/workflows/sdk-size-checks.yml Outdated
@gpunto gpunto force-pushed the sdk-size-checks-permissions branch from 890f721 to bbae9fc Compare April 29, 2026 15:50
@sonarqubecloud
Copy link
Copy Markdown

@gpunto gpunto merged commit 00c5127 into develop Apr 29, 2026
16 checks passed
@gpunto gpunto deleted the sdk-size-checks-permissions branch April 29, 2026 15:57
@stream-public-bot stream-public-bot added the released Included in a release label May 5, 2026
@stream-public-bot
Copy link
Copy Markdown
Contributor

🚀 Available in v7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants