fix: Add missing ngZone reenters #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've realized that if we want to hide the change detection optimizations from integrators, we would need to add a lot of unnecessary change detection runs to our SDK code, which could hurt us in high-traffic use cases. I think it's better to not hide it, but state this in the docs clearly (I've added a guide about this in this PR). |
petyosi
approved these changes
Dec 13, 2021
szuperaz
force-pushed
the
channel_and_notification_events
branch
2 times, most recently
from
bfa651d to
ac8efe4
Compare
szuperaz
force-pushed
the
channel_and_notification_events
branch
from
7ed4398 to
d2995ac
Compare
Contributor
Author
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #140