Skip to content

Conversation

@szuperaz
Copy link
Contributor

@szuperaz szuperaz commented Mar 23, 2022

BREAKING CHANGE ChatClient.notification$ renamed to events$

closes #214

@szuperaz szuperaz requested a review from petyosi March 23, 2022 10:29
@szuperaz szuperaz force-pushed the rename-notifications$ branch from e9b2f20 to 98f705a Compare March 23, 2022 10:30
Copy link
Contributor

@petyosi petyosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the base be encapsulate-stream-chat-css?

@szuperaz
Copy link
Contributor Author

Should the base be encapsulate-stream-chat-css?

No, I'll change it before merge, but that was the branch I created this branch from

@szuperaz szuperaz force-pushed the encapsulate-stream-chat-css branch 3 times, most recently from 5ab4fea to 0dad67f Compare March 23, 2022 13:40
Base automatically changed from encapsulate-stream-chat-css to beta March 23, 2022 13:47
@szuperaz szuperaz force-pushed the rename-notifications$ branch 2 times, most recently from 388712a to 5569f7c Compare March 23, 2022 13:53
**BREAKING CHANGE** `ChatClient.notification$` renamed to `events$`
@szuperaz szuperaz force-pushed the rename-notifications$ branch from 5569f7c to be38cbd Compare March 23, 2022 13:53
@szuperaz szuperaz merged commit 7bc6843 into beta Mar 23, 2022
@szuperaz szuperaz deleted the rename-notifications$ branch March 23, 2022 14:00
@szuperaz
Copy link
Contributor Author

🎉 This PR is included in version 3.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@szuperaz
Copy link
Contributor Author

szuperaz commented Apr 6, 2022

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants