Skip to content

Attachment fix, edit action, modal layout fix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szuperaz merged 3 commits into from
Nov 16, 2021
Merged

Attachment fix, edit action, modal layout fix #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9292266
Fix modal opacity
szuperaz Nov 15, 2021
1f53523
Don't hide edit modal if focus lost (Angular only)
szuperaz Nov 15, 2021
4bda885
Refactor Angular attachment display
szuperaz Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/styles/Message.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,11 @@
position: relative;
display: none;
}

&--options.str-chat-angular__message-simple__actions__action--options--editing {
position: relative;
display: flex;
}
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/styles/MessageInputFlat.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@
}
}

.rfu-image-previewer {
.rfu-image-previewer,
.rfu-image-previewer-angular-host {
flex: 1 1 100%;

&__image {
Expand Down
3 changes: 1 addition & 2 deletions src/styles/Modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
.str-chat__modal {
background: var(--black);
background: var(--modal-overlay-color);
Copy link
Copy Markdown
Contributor Author

@szuperaz szuperaz Nov 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects the React SDK as well

The problem was that not only the modal layout was transparent, but the modal itself (before and after screenshots attached)
Screenshot 2021-11-15 at 17 11 14

Screenshot 2021-11-15 at 17 21 09

Copy link
Copy Markdown
Contributor Author

@szuperaz szuperaz Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanC5 for some reason I couldn't add you as a reviewer, but please review this MR

position: fixed;
top: 0;
left: 0;
width: 100%;
height: 100%;
z-index: 10000;
opacity: 0.89;
display: none;
align-items: center;
justify-content: center;
Expand Down
2 changes: 2 additions & 0 deletions src/styles/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,6 @@ $border-radius: 16px;
--white: #ffffff;
--white-smoke: #f2f2f2;
--white-snow: #fcfcfc;

--modal-overlay-color: rgba(0, 0, 0, 0.89);
}