fix: add margin only to other users' messages without open actions dialog#324
Merged
MartinCupela merged 1 commit intomainfrom Feb 5, 2025
Merged
Conversation
szuperaz
approved these changes
Feb 4, 2025
MartinCupela
deleted the
fix/remove-margin-active-message-options-react
branch
|
🎉 This PR is included in version 5.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Applies to React SDK only. The SDK displays the message actions dialog over an overlay. Once the overlay is displayed, the message hover styles are removed. Other users' messages that are not hovered over are applied margin on inline-end as a placeholder for message options. This PR fixes the state, when rendering the said overlay leads the message options being displayed with margin on inline-end. In narrow layouts this leads to message component jumping.
Fixes REACT-268