Skip to content

Window thread update#42

Merged
ambaldwin merged 2 commits intodevelopfrom
window-thread-update
Feb 9, 2022
Merged

Window thread update#42
ambaldwin merged 2 commits intodevelopfrom
window-thread-update

Conversation

@ambaldwin
Copy link
Copy Markdown
Contributor

Add a hideOnThread class on the main panel (Window component) to correspond with the Window prop of the same name to handle the true value via CSS rather than in the component to prevent remounting of the list. Also, fixed the full class for Thread too correspond with the fullWidth prop there.

@ambaldwin ambaldwin requested review from petyosi and szuperaz February 8, 2022 22:48
@petyosi
Copy link
Copy Markdown
Contributor

petyosi commented Feb 9, 2022

@ambaldwin can you test this change with the virtualized message list? I am not sure if display: none won't interfere with the measurements. The test case should be the following:

  • Use the virtualized message list in the sample app
  • Scroll up to a certain location
  • Open a thread so that the main part is hidden
  • Close the thread

The main list should remain at the same position.

@ambaldwin
Copy link
Copy Markdown
Contributor Author

@ambaldwin can you test this change with the virtualized message list? I am not sure if display: none won't interfere with the measurements. The test case should be the following:

  • Use the virtualized message list in the sample app
  • Scroll up to a certain location
  • Open a thread so that the main part is hidden
  • Close the thread

The main list should remain at the same position.

@petyosi I tested this scenario and all appears well.

@ambaldwin ambaldwin merged commit c5419c8 into develop Feb 9, 2022
@ambaldwin ambaldwin deleted the window-thread-update branch February 9, 2022 17:38
@szuperaz
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants