Skip to content

Conversation

@xsahil03x
Copy link
Member

@xsahil03x xsahil03x commented Feb 24, 2025

This pull request addresses a bug fix related to the WebSocket connection in the stream_chat package. The most important changes include modifying the WebSocket closure logic.

Code Changes:

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.18%. Comparing base (78a6a99) to head (7c9c2a1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
- Coverage   60.19%   60.18%   -0.01%     
==========================================
  Files         382      382              
  Lines       23743    23742       -1     
==========================================
- Hits        14291    14290       -1     
  Misses       9452     9452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsahil03x xsahil03x merged commit 94cc695 into master Feb 25, 2025
14 checks passed
@xsahil03x xsahil03x deleted the fix/failed-to-execute-close-on-ws branch February 25, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidAccessError: Failed to execute 'close' on 'WebSocket': The code must be either 1000, or between 3000 and 4999. 1001 is neither.

3 participants