Skip to content

test(ui): fix tests#2500

Merged
xsahil03x merged 1 commit intomasterfrom
fix/test
Feb 2, 2026
Merged

test(ui): fix tests#2500
xsahil03x merged 1 commit intomasterfrom
fix/test

Conversation

@xsahil03x
Copy link
Copy Markdown
Member

@xsahil03x xsahil03x commented Feb 2, 2026

Need to update the fake due to a new release
https://pub.dev/packages/record/changelog#620

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure to support additional recording permission handling scenarios.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Updated the hasPermission method signature in FakeRecordPlatform by adding an optional named parameter request with a default value of true. The method behavior remains unchanged, returning true consistently.

Changes

Cohort / File(s) Summary
Test Mock Updates
packages/stream_chat_flutter/test/src/fakes.dart
Added optional named parameter {bool request = true} to hasPermission method in FakeRecordPlatform class, enabling greater flexibility in test call-sites while maintaining backward compatibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A parameter joins the fold,
With defaults, more stories told,
The fake now stands stronger still,
Ready to bend to the tester's will,
One tiny change, flexible and bold! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "test(ui): fix tests" is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific change. Use a more specific title that describes the actual change, such as "test: add optional request parameter to FakeRecordPlatform.hasPermission" to clarify what tests are being fixed and why.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xsahil03x xsahil03x merged commit e2c4971 into master Feb 2, 2026
18 of 19 checks passed
@xsahil03x xsahil03x deleted the fix/test branch February 2, 2026 14:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.74%. Comparing base (afd9362) to head (e6d4823).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
- Coverage   66.58%   64.74%   -1.85%     
==========================================
  Files         430      422       -8     
  Lines       26811    26438     -373     
==========================================
- Hits        17851    17116     -735     
- Misses       8960     9322     +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants