fix(ui): fix keystroke reporting#2545
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/design-refresh #2545 +/- ##
=======================================================
+ Coverage 64.77% 64.78% +0.01%
=======================================================
Files 437 437
Lines 26536 26546 +10
=======================================================
+ Hits 17189 17199 +10
Misses 9347 9347 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/stream_chat_flutter/test/src/message_input/message_input_test.dart (2)
446-447: Comment/duration mismatch.The comment states "350ms" but the pump duration is 1 second. Consider updating the comment to accurately reflect the actual duration or adjust the duration to match.
- // Pump past the debounce/throttle timers (350ms) - await tester.pump(const Duration(seconds: 1)); + // Pump past the debounce/throttle timers + await tester.pump(const Duration(milliseconds: 350));Alternatively, if 1 second is intentional for other reasons (e.g., accounting for async operations), update the comment accordingly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/stream_chat_flutter/test/src/message_input/message_input_test.dart` around lines 446 - 447, The inline comment above the tester.pump call is inconsistent: it says "350ms" but the code calls await tester.pump(const Duration(seconds: 1)); — update the comment to match the actual Duration (e.g., change to "1s" or "1000ms") or change the Duration to 350 milliseconds if that was the intended debounce/throttle wait; ensure you modify the comment next to the tester.pump(...) invocation so the comment and Duration remain consistent.
488-489: Same comment/duration mismatch as above.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/stream_chat_flutter/test/src/message_input/message_input_test.dart` around lines 488 - 489, The comment says "Pump past the debounce/throttle timers (350ms)" but the test uses await tester.pump(const Duration(seconds: 1)), causing a comment/duration mismatch; update either the comment or the Duration in the test in message_input_test.dart (the test around the "Pump past the debounce/throttle timers" line) so they match — replace Duration(seconds: 1) with Duration(milliseconds: 350) if you intend to wait 350ms, or change the comment to reflect 1 second if that was intentional.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/stream_chat_flutter/test/src/message_input/message_input_test.dart`:
- Around line 446-447: The inline comment above the tester.pump call is
inconsistent: it says "350ms" but the code calls await tester.pump(const
Duration(seconds: 1)); — update the comment to match the actual Duration (e.g.,
change to "1s" or "1000ms") or change the Duration to 350 milliseconds if that
was the intended debounce/throttle wait; ensure you modify the comment next to
the tester.pump(...) invocation so the comment and Duration remain consistent.
- Around line 488-489: The comment says "Pump past the debounce/throttle timers
(350ms)" but the test uses await tester.pump(const Duration(seconds: 1)),
causing a comment/duration mismatch; update either the comment or the Duration
in the test in message_input_test.dart (the test around the "Pump past the
debounce/throttle timers" line) so they match — replace Duration(seconds: 1)
with Duration(milliseconds: 350) if you intend to wait 350ms, or change the
comment to reflect 1 second if that was intentional.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 45ca077f-5c7f-4e7c-982b-3df8088f48a9
📒 Files selected for processing (2)
packages/stream_chat_flutter/lib/src/message_input/stream_message_input.dartpackages/stream_chat_flutter/test/src/message_input/message_input_test.dart
2 participants
Submit a pull request
Linear: FLU-425
Github Issue: #
CLA
Description of the pull request
Screenshots / Videos
Summary by CodeRabbit