Skip to content

refactor(ui): update ReactionIconResolver to return StreamEmojiContent instead of Widget#2591

Merged
xsahil03x merged 3 commits intofeat/design-refreshfrom
fix/reaction-alignment
Apr 2, 2026
Merged

refactor(ui): update ReactionIconResolver to return StreamEmojiContent instead of Widget#2591
xsahil03x merged 3 commits intofeat/design-refreshfrom
fix/reaction-alignment

Conversation

@xsahil03x
Copy link
Copy Markdown
Member

Description of the pull request

  • Breaking Change: Modified ReactionIconResolver.resolve signature to return StreamEmojiContent and removed the BuildContext parameter.
  • Updated DefaultReactionIconResolver to return StreamUnicodeEmoji by default.
  • Updated StreamMessageReactionPicker, StreamMessageReactions, ReactionDetailSheet, and StreamMessageReactions to use the new data-driven resolution logic.
  • Refactored DesktopReactionsBuilder to use StreamEmoji with the new resolver output.
  • Updated migration documentation and tests to reflect the shift from widget-based resolution to content-model resolution (supporting StreamImageEmoji for custom rendering like Twemoji).
  • Adjusted StreamGalleryPicker to use a transparent background for the overlay color.
  • Temporarily updated stream_core_flutter dependency to a local path.

…tent` instead of `Widget`

*   **Breaking Change**: Modified `ReactionIconResolver.resolve` signature to return `StreamEmojiContent` and removed the `BuildContext` parameter.
*   Updated `DefaultReactionIconResolver` to return `StreamUnicodeEmoji` by default.
*   Updated `StreamMessageReactionPicker`, `StreamMessageReactions`, `ReactionDetailSheet`, and `StreamMessageReactions` to use the new data-driven resolution logic.
*   Refactored `DesktopReactionsBuilder` to use `StreamEmoji` with the new resolver output.
*   Updated migration documentation and tests to reflect the shift from widget-based resolution to content-model resolution (supporting `StreamImageEmoji` for custom rendering like Twemoji).
*   Adjusted `StreamGalleryPicker` to use a transparent background for the overlay color.
*   Temporarily updated `stream_core_flutter` dependency to a local path.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e58b9dd-d072-44fd-89bc-b981bbe738b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/reaction-alignment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xsahil03x xsahil03x changed the title refactor(ui): update ReactionIconResolver to return StreamEmojiContent instead of `Widget refactor(ui): update ReactionIconResolver to return StreamEmojiContent instead of Widget Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.32%. Comparing base (cd3cd88) to head (7a6302e).
⚠️ Report is 1 commits behind head on feat/design-refresh.

Files with missing lines Patch % Lines
...ge_widget/components/stream_message_reactions.dart 0.00% 1 Missing ⚠️
...chat_flutter/lib/src/reactions/user_reactions.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/design-refresh    #2591   +/-   ##
====================================================
  Coverage                65.32%   65.32%           
====================================================
  Files                      429      429           
  Lines                    26137    26133    -4     
====================================================
- Hits                     17073    17071    -2     
+ Misses                    9064     9062    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x xsahil03x merged commit f24077a into feat/design-refresh Apr 2, 2026
8 of 9 checks passed
@xsahil03x xsahil03x deleted the fix/reaction-alignment branch April 2, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants