refactor(ui): update ReactionIconResolver to return StreamEmojiContent instead of Widget#2591
Conversation
…tent` instead of `Widget` * **Breaking Change**: Modified `ReactionIconResolver.resolve` signature to return `StreamEmojiContent` and removed the `BuildContext` parameter. * Updated `DefaultReactionIconResolver` to return `StreamUnicodeEmoji` by default. * Updated `StreamMessageReactionPicker`, `StreamMessageReactions`, `ReactionDetailSheet`, and `StreamMessageReactions` to use the new data-driven resolution logic. * Refactored `DesktopReactionsBuilder` to use `StreamEmoji` with the new resolver output. * Updated migration documentation and tests to reflect the shift from widget-based resolution to content-model resolution (supporting `StreamImageEmoji` for custom rendering like Twemoji). * Adjusted `StreamGalleryPicker` to use a transparent background for the overlay color. * Temporarily updated `stream_core_flutter` dependency to a local path.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ReactionIconResolver to return StreamEmojiContent instead of `WidgetReactionIconResolver to return StreamEmojiContent instead of Widget
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/design-refresh #2591 +/- ##
====================================================
Coverage 65.32% 65.32%
====================================================
Files 429 429
Lines 26137 26133 -4
====================================================
- Hits 17073 17071 -2
+ Misses 9064 9062 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description of the pull request
ReactionIconResolver.resolvesignature to returnStreamEmojiContentand removed theBuildContextparameter.DefaultReactionIconResolverto returnStreamUnicodeEmojiby default.StreamMessageReactionPicker,StreamMessageReactions,ReactionDetailSheet, andStreamMessageReactionsto use the new data-driven resolution logic.DesktopReactionsBuilderto useStreamEmojiwith the new resolver output.StreamImageEmojifor custom rendering like Twemoji).StreamGalleryPickerto use a transparent background for the overlay color.stream_core_flutterdependency to a local path.