fix(ui): apply filter of supported emoji#2698
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| final selectedReactions = ownReactionsMap.keys.toSet(); | ||
| final supportedEmojis = resolver.supportedReactions | ||
| .map((type) => streamSupportedEmojis[type]) | ||
| .whereType<StreamEmojiData>(); |
There was a problem hiding this comment.
we can use .nonNulls instead of whereType
There was a problem hiding this comment.
Also better to create a list .toList
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v10.0.0 #2698 +/- ##
==========================================
Coverage ? 67.47%
==========================================
Files ? 407
Lines ? 24430
Branches ? 0
==========================================
Hits ? 16485
Misses ? 7945
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docsGoldenTest's default pumpBeforeTest now calls pumpAndSettle before precacheImages, so modal sheets and paginated list views finish rendering before the image scan runs — fixing the empty avatar circles in the reaction detail sheet and reaction list view goldens. Reaction stubs move into the test builders now that custom pumpBeforeTest overrides are no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 participants
Submit a pull request
CLA
Description of the pull request
This checks the supportedReactions for the picker sheets.