Skip to content

fix(ci): add multi_json to sample_app Gemfiles#2728

Merged
xsahil03x merged 1 commit into
masterfrom
fix/ci-multi-json-bundle
Jun 5, 2026
Merged

fix(ci): add multi_json to sample_app Gemfiles#2728
xsahil03x merged 1 commit into
masterfrom
fix/ci-multi-json-bundle

Conversation

@xsahil03x
Copy link
Copy Markdown
Member

@xsahil03x xsahil03x commented Jun 5, 2026

Summary

  • Sample-app Android & iOS builds started failing on PRs with bundler: failed to load command: fastlane … multi_json is not part of the bundle.
  • Root cause: representable (pulled in transitively by fastlane → google-apis-playcustomapp_v1 → google-apis-core) does require 'multi_json' but no longer declares it as a runtime dep. With no Gemfile.lock in the repo, each CI run resolves fresh from rubygems, and a recently published gem version dropped multi_json from the transitive chain. Ruby 3.3's stricter bundle enforcement then turns the missing gem into a hard LoadError.
  • Fix: declare gem "multi_json" explicitly in both sample_app/android/Gemfile and sample_app/ios/Gemfile.

This is latent on master (build job is skipped on push) and currently surfacing on PRs targeting v10.0.0 (e.g. #2716, #2679). Landing on master and merging down to v10.0.0 unblocks both.

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added multi_json dependency to Android and iOS build configurations.

Without an explicit `gem "multi_json"`, recent gem resolutions on
Ruby 3.3 fail at `bundle exec fastlane` startup with
`multi_json is not part of the bundle` — representable still
`require`s it, but newer fastlane/google-apis dependency chains no
longer pull it in transitively.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80441493-7631-428e-a557-eaee872b9257

📥 Commits

Reviewing files that changed from the base of the PR and between 13798f0 and ed5819b.

📒 Files selected for processing (2)
  • sample_app/android/Gemfile
  • sample_app/ios/Gemfile

📝 Walkthrough

Walkthrough

The multi_json gem dependency is added to both the Android and iOS sample app Gemfiles as a new direct dependency alongside existing gems like fastlane and cocoapods.

Changes

Multi-JSON Dependency Addition

Layer / File(s) Summary
Add multi_json gem to sample apps
sample_app/android/Gemfile, sample_app/ios/Gemfile
The multi_json gem is declared in both the Android and iOS sample app Gemfiles.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • VelikovPetar
  • renefloor

Poem

🐰 A gem so small, yet needed twice,
Through Android, iOS—oh so nice!
Multi-json hops along the way,
Simplifying data every day! 📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding multi_json dependency to sample app Gemfiles. It is specific, concise, and directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-multi-json-bundle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.66%. Comparing base (13798f0) to head (ed5819b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2728   +/-   ##
=======================================
  Coverage   65.66%   65.66%           
=======================================
  Files         424      424           
  Lines       26724    26724           
=======================================
  Hits        17549    17549           
  Misses       9175     9175           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x xsahil03x merged commit b8d222f into master Jun 5, 2026
26 checks passed
@xsahil03x xsahil03x deleted the fix/ci-multi-json-bundle branch June 5, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants