fix(ci): add multi_json to sample_app Gemfiles#2728
Conversation
Without an explicit `gem "multi_json"`, recent gem resolutions on Ruby 3.3 fail at `bundle exec fastlane` startup with `multi_json is not part of the bundle` — representable still `require`s it, but newer fastlane/google-apis dependency chains no longer pull it in transitively. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe ChangesMulti-JSON Dependency Addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2728 +/- ##
=======================================
Coverage 65.66% 65.66%
=======================================
Files 424 424
Lines 26724 26724
=======================================
Hits 17549 17549
Misses 9175 9175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
bundler: failed to load command: fastlane … multi_json is not part of the bundle.representable(pulled in transitively byfastlane → google-apis-playcustomapp_v1 → google-apis-core) doesrequire 'multi_json'but no longer declares it as a runtime dep. With noGemfile.lockin the repo, each CI run resolves fresh from rubygems, and a recently published gem version droppedmulti_jsonfrom the transitive chain. Ruby 3.3's stricter bundle enforcement then turns the missing gem into a hardLoadError.gem "multi_json"explicitly in bothsample_app/android/Gemfileandsample_app/ios/Gemfile.This is latent on
master(build job is skipped on push) and currently surfacing on PRs targetingv10.0.0(e.g. #2716, #2679). Landing onmasterand merging down tov10.0.0unblocks both.Test plan
build (android)passes on this PRbuild (ios)passes on this PRmasterintov10.0.0and confirm docs(ui): add more docs snapshots #2716 builds pass🤖 Generated with Claude Code
Summary by CodeRabbit
multi_jsondependency to Android and iOS build configurations.