Added QueryMessageFlags client method#125
Merged
ferhatelmas merged 5 commits intomasterfrom May 21, 2021
Merged
Conversation
gumuz
commented
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 55.14% 56.02% +0.87%
==========================================
Files 14 14
Lines 903 921 +18
==========================================
+ Hits 498 516 +18
+ Misses 318 313 -5
- Partials 87 92 +5
Continue to review full report at Codecov.
|
gumuz
commented
May 21, 2021
| ct, err := c.CreateChannelType(ct) | ||
| require.NoError(t, err, "create channel type") | ||
|
|
||
| time.Sleep(6 * time.Second) |
Contributor
Author
There was a problem hiding this comment.
I believe there was a latency/timing issue here, where the new ChannelType wasn't directly available to the test that created them, which resulted in a flaky test
ferhatelmas
reviewed
May 21, 2021
| .envrc | ||
|
|
||
| # vendored dependencies and binaries | ||
| vendor/ No newline at end of file |
Contributor
There was a problem hiding this comment.
this is actually need since we don't vendor but having doesn't hurt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.