Conversation
some customers have conflicts for this dependency
also shadow io.jsonwebtoken
skydoves
reviewed
Aug 7, 2024
skydoves
left a comment
skydoves
left a comment
There was a problem hiding this comment.
The maven configuration looks good to me :)
skydoves
reviewed
Aug 7, 2024
shaljam
force-pushed
the
shadow-jsonwebtoken
branch
from
4f4f5cb to
ddcd88b
Compare
itsmeadi
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
Some customers had conflicts with ones of our dependencies (
jjwt). This PR createsstream-chat-java-allartifact, which shadows all the dependencies, resolving dependency conflicts now and potentially in the future.