Skip to content

Conversation

@javierdfm
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025

Size Change: 0 B

Total Size: 454 kB

ℹ️ View Unchanged
Filename Size
dist/cjs/index.browser.cjs 130 kB
dist/cjs/index.node.cjs 182 kB
dist/esm/index.js 142 kB

compressed-size-action

@javierdfm javierdfm requested a review from MartinCupela August 4, 2025 07:50
@MartinCupela
Copy link
Contributor

@javierdfm one more thing comes to my mind is the naming of the config field message_count_enabled. None of the rest of the fields has this enabled appended even though all of the fields there are about enabling / disabling a feature. And the name message_count does not say much about what is being enabled.

Is this feature a message_count_in_channel_payload?
Is this the total message count?
Including the moderated messages?

@javierdfm
Copy link
Contributor Author

@javierdfm one more thing comes to my mind is the naming of the config field message_count_enabled. None of the rest of the fields has this enabled appended even though all of the fields there are about enabling / disabling a feature. And the name message_count does not say much about what is being enabled.

Is this feature a message_count_in_channel_payload? Is this the total message count? Including the moderated messages?

The feature enables counting messages in a channel (user generated messages like regular and replies) and exposing this count to the clients so it can be shown in the overview. Let me see if I can come up with a better name if this is not clear.

@javierdfm javierdfm merged commit c58fd6f into master Aug 14, 2025
4 checks passed
@javierdfm javierdfm deleted the cha-1045-add-channel-message-count-response branch August 14, 2025 09:01
github-actions bot pushed a commit that referenced this pull request Aug 14, 2025
## [9.16.0](v9.15.0...v9.16.0) (2025-08-14)

### Features

* add channel message count response fields ([#1594](#1594)) ([c58fd6f](c58fd6f))
@stream-ci-bot
Copy link

🎉 This PR is included in version 9.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants