fix: prevent dispatchEvent crash on uninitialized channels via muteStatus#1740
Merged
Merged
Conversation
Contributor
|
Size Change: +6 B (0%) Total Size: 381 kB 📦 View Changed
|
MartinCupela
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Fixes #1732.
When a
message.newarrives for a channel that's inactiveChannelsbut hasn't been watched yet,dispatchEventthrows. Happens during deep-link navigation (gap betweenclient.channel(...)and.watch()resolving) and on screens that fetch viaquery({ watch: false })and never watch.The crash path is
dispatchEvent → _handleChannelEvent → _countMessageAsUnread → muteStatus() → _checkInitialized()._countMessageAsUnreadis internal bookkeeping but was going through the publicmuteStatus()which gates on initialization. The throw escapes_handleChannelEventand kills the rest of the dispatch cycle, so listeners and the offline-db handler for that event never run.