Skip to content

feat: add portuguese translation#2224

Merged
khushal87 merged 6 commits intoGetStream:developfrom
arthurgeron:task/portuguese-translation
Mar 1, 2024
Merged

feat: add portuguese translation#2224
khushal87 merged 6 commits intoGetStream:developfrom
arthurgeron:task/portuguese-translation

Conversation

@arthurgeron
Copy link
Copy Markdown
Contributor

@arthurgeron arthurgeron commented Sep 1, 2023

🎯 Goal

  • Add Brazilian Portuguese translation

πŸ›  Implementation details

  • Added relevant info to translations doc

Continuation of PR #2120

🎨 UI Changes

N/A

πŸ§ͺ Testing

Use Streami18n and set language to pt-BR

β˜‘οΈ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@khushal87 khushal87 changed the title Task/portuguese translation feat: add portuguese translation Jan 3, 2024
@khushal87
Copy link
Copy Markdown
Contributor

Hey @arthurgeron, sorry for a delayed response on the PR. Can you please resolve the conflicts and make sure all the new keys are added to your PR as per https://github.com/GetStream/stream-chat-react-native/blob/develop/package/src/i18n/en.json. Thanks πŸ˜„

@khushal87 khushal87 self-requested a review January 3, 2024 10:31
@khushal87
Copy link
Copy Markdown
Contributor

Hey, @arthurgeron, the PR is getting stale. Can you look into the comment above and update the translations accordingly. Thanks πŸ˜„

@arthurgeron
Copy link
Copy Markdown
Contributor Author

Hey, @arthurgeron, the PR is getting stale. Can you look into the comment above and update the translations accordingly. Thanks πŸ˜„

@khushal87 Thanks for the nudge! Noted that the PR had been pending for quite a while. Currently swamped, but I'll circle back to it when possible. Meanwhile, feel free to jump in and update the translations if you have the bandwidth.

@khushal87
Copy link
Copy Markdown
Contributor

Hey @arthurgeron, I have pushed the changes to your PR and is now merging it. Thanks πŸ˜„

@khushal87 khushal87 merged commit ecffe87 into GetStream:develop Mar 1, 2024
@arthurgeron arthurgeron deleted the task/portuguese-translation branch March 1, 2024 09:29
@github-actions github-actions Bot mentioned this pull request Mar 7, 2024
@stream-ci-bot
Copy link
Copy Markdown
Contributor

πŸŽ‰ This PR is included in version 5.26.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants