fix: keyboard transition issue when switching from attachment picker to keyboard#2404
Merged
Conversation
santhoshvai
reviewed
Jan 26, 2024
| @@ -193,7 +199,7 @@ export const AttachmentPicker = React.forwardRef( | |||
| // To keep compatibility with older versions of React Native, where `remove()` is not available | |||
| Keyboard.removeListener(keyboardShowEvent, closePicker); | |||
Member
There was a problem hiding this comment.
Suggested change
| Keyboard.removeListener(keyboardShowEvent, closePicker); | |
| Keyboard.removeListener(keyboardShowEvent, onKeyboardOpenHandler); |
santhoshvai
reviewed
Jan 26, 2024
Comment on lines
+185
to
+187
| if (selectedPicker) { | ||
| setSelectedPicker(undefined); | ||
| } |
Member
There was a problem hiding this comment.
cant this be done like this without if?
setSelectedPicker(undefined)
there is no need for an if at all.. if you want it to set it to undefined whenever keyboard is open
Contributor
Author
There was a problem hiding this comment.
Ideally, it won't create much of a difference. Its just a sanity check that we set it as undefined only when there is a value in the selectedPicker state. The same is done for the back action handler in the file.
Contributor
|
🎉 This PR is included in version 5.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes #2024
Before:
Screen.Recording.2024-01-22.at.11.55.09.PM.mov
After:
Screen.Recording.2024-01-23.at.12.03.23.PM.mov
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch