fix: theme for MessageList and SendMessageDisallowedIndicator#2470
Merged
fix: theme for MessageList and SendMessageDisallowedIndicator#2470
Conversation
khushal87
commented
Apr 1, 2024
| theme={{ | ||
| colors: { | ||
| ...(colorScheme === 'dark' ? DarkTheme : DefaultTheme).colors, | ||
| background: theme.colors?.white_snow || '#FCFCFC', |
Contributor
Author
There was a problem hiding this comment.
Not needed in TSMessagingApp. Since removing it will give us a fair idea about the component's default theme.
Contributor
Author
|
Merging after self review ✅ |
Merged
santhoshvai
reviewed
Apr 2, 2024
| <View style={[styles.container, container]}> | ||
| <Spinner /> | ||
| <View style={[styles.container, { backgroundColor: white_snow }, container]}> | ||
| <Spinner height={20} width={20} /> |
Member
There was a problem hiding this comment.
<Spinner height={20} width={20} /> is better as <Spinner />
Looking at this, it seems like the spinner component itself is bad to me.. the style by default has height and width of 16, but the icon doesnt have.. so its easier if we pass a default of 16 to the icon when no prop is passed and as a long term view, better
Contributor
|
🎉 This PR is included in version 5.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR fixes the theme for the
MessageListand theSendMessageDisallowedIndicatorcomponents. The background colour is especially fixed, which was white for most cases if no external colour is applied.The empty state spinner was also not rendering. That is also fixed in the PR.
Before:
RPReplay_Final1711957583.MP4
After:
RPReplay_Final1711959352.MP4
🛠 Implementation details
🎨 UI Changes
🧪 Testing
☑️ Checklist
developbranch