Merged
Conversation
Contributor
SDK Size
|
# Conflicts: # package/src/i18n/ko.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the message reaction overlay and emoji picker functionality to improve user experience and code clarity. The main changes include replacing the previous overlay for message reactions with a dedicated bottom sheet modal, updating the reaction list components to use a new callback (
showReactionsOverlay), and enhancing the emoji picker to visually indicate selected emojis and streamline its API.Message Reaction Overlay Refactor:
BottomSheetModalthat displaysMessageUserReactions, providing a more consistent and modern UI for viewing reactions. (package/src/components/Message/Message.tsx, package/src/components/Message/Message.tsxL886-R915)showReactionsOverlaycallback (usinguseStableCallback) to handle opening the reactions modal, separating it from the general message overlay logic. (package/src/components/Message/Message.tsx, [1] [2] [3] [4]Reaction List API Update:
ReactionListTopandReactionListBottomcomponents and their props to useshowReactionsOverlayinstead ofshowMessageOverlay, clarifying intent and improving maintainability. (package/src/components/MessageSimple/ReactionList/ReactionListBottom.tsx, [1] [2] [3] [4] [5] [6] [7] [8];package/src/components/MessageSimple/ReactionList/ReactionListTop.tsx, [9] [10] [11] [12] [13] [14]Emoji Picker Improvements:
EmojiPickerListto visually highlight emojis the user has already reacted with, using a newselectedEmojistyle. (package/src/components/MessageMenu/EmojiPickerList.tsx, [1] [2]onSelectReactioninstead ofonSelectEmoji, simplifying integration with the reaction handler and improving clarity. (package/src/components/MessageMenu/EmojiPickerList.tsx, [1] [2];package/src/components/MessageMenu/MessageReactionPicker.tsx, [3] [4]Supporting Changes:
useStableCallbackandBottomSheetModalto relevant files. (package/src/components/Message/Message.tsx, [1] [2]showMessageReactionstofalse, so reactions overlay is only shown when explicitly triggered. (package/src/components/Message/Message.tsx, package/src/components/Message/Message.tsxL244-R246)