Skip to content

fix: revert back to old pagination defaults #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isekovanic merged 5 commits into from
Feb 23, 2026
Merged

fix: revert back to old pagination defaults #3421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15eb843
fix: infinite loading in message list
isekovanic Feb 23, 2026
fb50b05
chore: bump sample app
isekovanic Feb 23, 2026
253a554
fix: revert back to old pagination defaults
isekovanic Feb 23, 2026
9297cdf
fix: tests
isekovanic Feb 23, 2026
c0bd083
Merge branch 'V8-release' into fix/infinite-loading-empty-list
isekovanic Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/SampleApp/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8349,10 +8349,10 @@ stream-chat-react-native-core@8.1.0:
version "0.0.0"
uid ""

stream-chat@^9.27.2:
version "9.27.2"
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-9.27.2.tgz#5b41173e513f3606c47c93f391693b589e663968"
integrity sha512-OdALDzg8lO8CAdl8deydJ1+O4wJ7mM9dPLeCwDppq/OQ4aFIS9X38P+IdXPcOCsgSS97UoVUuxD2/excC5PEeg==
stream-chat@^9.33.0:
version "9.35.1"
resolved "https://registry.yarnpkg.com/stream-chat/-/stream-chat-9.35.1.tgz#d828854a9c27ea7e45e6642d9107966c6606f552"
integrity sha512-649sgO7+llFuW+y/Ja0K4d94aUC+EMxYUVo5mq5AFGT86vUAIXmRIMVHYHA/jw4MYoqfWAFrDK6L9Rhyn/eMkQ==
dependencies:
"@types/jsonwebtoken" "^9.0.8"
"@types/ws" "^8.5.14"
Expand Down
8 changes: 4 additions & 4 deletions package/src/components/Channel/__tests__/useMessageListPagination.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ describe('useMessageListPagination', () => {

await waitFor(() => {
expect(queryFn).toHaveBeenCalledWith({
messages: { id_lt: messages[0].id },
watchers: {},
messages: { id_lt: messages[0].id, limit: 25 },
watchers: { limit: 25 },
});
expect(result.current.state.hasMore).toBe(true);
expect(result.current.state.messages.length).toBe(40);
Expand Down Expand Up @@ -252,8 +252,8 @@ describe('useMessageListPagination', () => {

await waitFor(() => {
expect(queryFn).toHaveBeenCalledWith({
messages: { id_gt: messages[messages.length - 1].id },
watchers: {},
messages: { id_gt: messages[messages.length - 1].id, limit: 10 },
watchers: { limit: 10 },
});
expect(result.current.state.hasMore).toBe(true);
expect(result.current.state.messages.length).toBe(40);
Expand Down
4 changes: 2 additions & 2 deletions package/src/components/Channel/hooks/useMessageListPagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const useMessageListPagination = ({ channel }: { channel: Channel }) => {
/**
* This function loads more messages before the first message in current channel state.
*/
const loadMore = useStableCallback(async (limit?: number) => {
const loadMore = useStableCallback(async (limit: number = 25) => {
if (!channel.state.messagePagination.hasPrev) {
return;
}
Expand Down Expand Up @@ -103,7 +103,7 @@ export const useMessageListPagination = ({ channel }: { channel: Channel }) => {
/**
* This function loads more messages after the most recent message in current channel state.
*/
const loadMoreRecent = useStableCallback(async (limit?: number) => {
const loadMoreRecent = useStableCallback(async (limit: number = 10) => {
if (!channel.state.messagePagination.hasNext) {
return;
}
Expand Down
Loading