Skip to content

fix: respect topInset on bottom sheet once again#3606

Merged
isekovanic merged 1 commit into
developfrom
fix/bottom-sheet-top-inset-calculation
May 19, 2026
Merged

fix: respect topInset on bottom sheet once again#3606
isekovanic merged 1 commit into
developfrom
fix/bottom-sheet-top-inset-calculation

Conversation

@isekovanic
Copy link
Copy Markdown
Contributor

🎯 Goal

This PR addresses a regression with our AttachmentPicker component which was done in order to fix accessibility issues. Namely, since we calculate the topInset for our BottomSheet in order to make it properly orderable by screen readers, the value for the global topInset was omitted.

This is wrong, because then the calculations are very wrong particularly in the cases of having native modals (i.e react-navigation/native-stack or expo-router) whose height we need to take into account, similarly to how we do it for keyboardVerticalOffset.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@isekovanic isekovanic requested review from oliverlaz and szuperaz May 19, 2026 14:40
@Stream-SDK-Bot
Copy link
Copy Markdown
Contributor

SDK Size

title develop branch diff status
js_bundle_size 368 KB 368 KB 0 B 🟢

@isekovanic isekovanic merged commit 0b7977a into develop May 19, 2026
5 checks passed
@isekovanic isekovanic deleted the fix/bottom-sheet-top-inset-calculation branch May 19, 2026 14:57
@github-actions github-actions Bot mentioned this pull request May 19, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants