fix: propagate user update data to UI #1566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Reflect updates to user's data in:
fixes #1565
🛠 Implementation details
MessageListThe change's are performed upon reception of WS event
user.updated. The implementation takes into account that a user can have custom fields and therefore the memoization inMessageListtakes this into account. Until now, the changes were propagated to the most bottom components only if user'simageornamechanged. Those are default attributes. Therefore if a customAvatarcomponent displays custom user data, their update would not be reflected until page is refreshed.ChannelPreviewThe
ChannelListcomponent neither its children were listening touser.updatedevent and therefore the event listener has been added to theChannelPreview's effect.Out of scope
ChannelHeaderdoes not display image if the channel is DM channel (channel.data.name === undefined). This could be considered a bug or insufficiency. TheChannelHeadershould probably behave the same way asChannelPreviewin terms of its title and displayed image to support consistency. This is out of scope of this PR, because it would introduced breaking changes in form of changed component behavior.