feat: provide close callback to app menu #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1754 +/- ##
===========================================
+ Coverage 79.59% 83.55% +3.95%
===========================================
Files 231 256 +25
Lines 5799 6239 +440
Branches 1644 1675 +31
===========================================
+ Hits 4616 5213 +597
+ Misses 1042 871 -171
- Partials 141 155 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
petyosi
previously approved these changes
Sep 15, 2022
oliverlaz
previously approved these changes
Sep 15, 2022
MartinCupela
changed the title
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
arnautov-anton
approved these changes
Sep 16, 2022
Contributor
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow users to pass a callback invoked once the app menu item is selected. The default
onSelectcallback closes theAppMenudropdown.