fix(VirtualizedMessageList): use memoized values as hook dependencies directly

[MartinCupela]

🎯 Goal

Avoid unnecessary re-renders caused by regenerating a new array of message group style keys (Object.keys() was called directly in the hook dependency array).

[codecov]

Codecov Report

Merging #1761 (f51f2a6) into develop (aeff06a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1761      +/-   ##
===========================================
- Coverage    83.58%   83.55%   -0.04%     
===========================================
  Files          256      256              
  Lines         6239     6239              
  Branches      1675     1675              
===========================================
- Hits          5215     5213       -2     
- Misses         869      871       +2     
  Partials       155      155              

Impacted Files	Coverage Δ
...mponents/ChannelList/hooks/usePaginatedChannels.ts	88.23% <ø> (ø)
.../components/MessageList/VirtualizedMessageList.tsx	64.17% <100.00%> (ø)
...omponents/MessageList/hooks/useEnrichedMessages.ts	86.36% <100.00%> (ø)
...components/Reactions/hooks/useProcessReactions.tsx	100.00% <100.00%> (ø)
src/components/Channel/Channel.tsx	80.45% <0.00%> (-0.66%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[petyosi]

I believe that we had a bug where processedMessages were incorrectly rebuilt with a new object identity at some point, hence the .length usage (which, of course, is not correct but we are not aware of any issues because of it).
Given that, I would say that this change should not touch on that.

[MartinCupela]

I believe that we had a bug where processedMessages were incorrectly rebuilt with a new object identity at some point, hence the .length usage (which, of course, is not correct but we are not aware of any issues because of it). Given that, I would say that this change should not touch on that.

@petyosi I have reverted the changes and added the explanatory comment for future reference.

[petyosi]

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀