Skip to content

Conversation

@MartinCupela
Copy link
Contributor

@MartinCupela MartinCupela commented May 5, 2023

🎯 Goal

Allow users to generate the default value for MessageInput components instead of providing static defaultValue through additionalTextareaProps. This circumvents the limitation posed by passing defaultValue to MessageInput in Thread component. If the default value has to be generated / retrieved, it cannot be set with the first render of the Thread component as the thread is not yet opened / known and the original defaultValue passed to Thread would not get overwritten once the thread value is set in ChatContext.

@MartinCupela MartinCupela marked this pull request as ready for review May 5, 2023 11:25
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (569c53d) to head (8e1bec4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2007   +/-   ##
========================================
  Coverage    82.00%   82.00%           
========================================
  Files          262      262           
  Lines         6428     6428           
  Branches      1809     1809           
========================================
  Hits          5271     5271           
  Misses         843      843           
  Partials       314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

oliverlaz
oliverlaz previously approved these changes May 5, 2023
MartinCupela and others added 2 commits May 5, 2023 15:21
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
@MartinCupela MartinCupela merged commit 9316bdf into develop May 5, 2023
@MartinCupela MartinCupela deleted the feat/get-default-input-message-dynamically branch May 5, 2023 13:46
@MartinCupela MartinCupela mentioned this pull request May 5, 2023
github-actions bot pushed a commit that referenced this pull request May 5, 2023
# [10.8.0](v10.7.6...v10.8.0) (2023-05-05)

### Bug Fixes

* prevent duplicate simultaneous query channel quests ([#2004](#2004)) ([33411b8](33411b8))
* prevent overriding event handlers in MessageInput's Textarea component ([#2006](#2006)) ([569c53d](569c53d))

### Features

* allow to retrieve the default message input value dynamically ([#2007](#2007)) ([9316bdf](9316bdf))
@github-actions
Copy link

github-actions bot commented May 5, 2023

🎉 This PR is included in version 10.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants