-
Notifications
You must be signed in to change notification settings - Fork 290
feat: allow to retrieve the default message input value dynamically #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MartinCupela
merged 7 commits into
develop
from
feat/get-default-input-message-dynamically
May 5, 2023
Merged
feat: allow to retrieve the default message input value dynamically #2007
MartinCupela
merged 7 commits into
develop
from
feat/get-default-input-message-dynamically
May 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2007 +/- ##
========================================
Coverage 82.00% 82.00%
========================================
Files 262 262
Lines 6428 6428
Branches 1809 1809
========================================
Hits 5271 5271
Misses 843 843
Partials 314 314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docusaurus/docs/React/guides/customization/persist-input-text-in-local-storage.mdx
Outdated
Show resolved
Hide resolved
docusaurus/docs/React/guides/customization/persist-input-text-in-local-storage.mdx
Outdated
Show resolved
Hide resolved
oliverlaz
previously approved these changes
May 5, 2023
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
arnautov-anton
approved these changes
May 5, 2023
Merged
github-actions bot
pushed a commit
that referenced
this pull request
May 5, 2023
# [10.8.0](v10.7.6...v10.8.0) (2023-05-05) ### Bug Fixes * prevent duplicate simultaneous query channel quests ([#2004](#2004)) ([33411b8](33411b8)) * prevent overriding event handlers in MessageInput's Textarea component ([#2006](#2006)) ([569c53d](569c53d)) ### Features * allow to retrieve the default message input value dynamically ([#2007](#2007)) ([9316bdf](9316bdf))
|
🎉 This PR is included in version 10.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow users to generate the default value for
MessageInputcomponents instead of providing staticdefaultValuethroughadditionalTextareaProps. This circumvents the limitation posed by passingdefaultValuetoMessageInputinThreadcomponent. If the default value has to be generated / retrieved, it cannot be set with the first render of theThreadcomponent as the thread is not yet opened / known and the originaldefaultValuepassed toThreadwould not get overwritten once thethreadvalue is set inChatContext.