Skip to content

fix: prevent overriding active channel UI on ChannelList pagination error#3164

Merged
MartinCupela merged 1 commit intomasterfrom
fix/show-available-channel-on-channel-list-pagination-error
May 4, 2026
Merged

fix: prevent overriding active channel UI on ChannelList pagination error#3164
MartinCupela merged 1 commit intomasterfrom
fix/show-available-channel-on-channel-list-pagination-error

Conversation

@MartinCupela
Copy link
Copy Markdown
Contributor

@MartinCupela MartinCupela commented May 4, 2026

🎯 Goal

Developers, who worked on Channel.tsx implemented the logic of what is displayed in Channel component coupled to what happens in the ChannelList pagination (not SDK development, but app development pattern). This PR prevents overriding Channel UI just because during the channel pagination an error occurred. It is rather unexpected from the app user point of view to loose the all the information in the chat just because the one page of items could not be solved in the channel list sidebar.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.53%. Comparing base (76228d8) to head (8ab573c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3164   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files         434      434           
  Lines       12928    12928           
  Branches     4161     4161           
=======================================
  Hits        10800    10800           
  Misses       2128     2128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Size Change: +3 B (0%)

Total Size: 672 kB

📦 View Changed
Filename Size Change
dist/cjs/emojis.js 3.01 kB -2 B (-0.07%)
dist/cjs/index.js 267 kB -1 B (0%)
dist/es/emojis.mjs 2.52 kB +3 B (+0.12%)
dist/es/useNotificationApi.mjs 45.2 kB +3 B (+0.01%)
ℹ️ View Unchanged
Filename Size
dist/cjs/audioProcessing.js 1.32 kB
dist/cjs/mp3-encoder.js 1.27 kB
dist/cjs/useNotificationApi.js 45.4 kB
dist/css/emoji-picker.css 178 B
dist/css/emoji-replacement.css 456 B
dist/css/index.css 39.3 kB
dist/es/audioProcessing.mjs 1.31 kB
dist/es/index.mjs 265 kB
dist/es/mp3-encoder.mjs 756 B

compressed-size-action

@MartinCupela MartinCupela merged commit 0c0d65c into master May 4, 2026
10 checks passed
@MartinCupela MartinCupela deleted the fix/show-available-channel-on-channel-list-pagination-error branch May 4, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants