Make the Logger thread-safe to avoid crashes #2775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
Contributor
martinmitrevski
left a comment
martinmitrevski
left a comment
There was a problem hiding this comment.
Looks good, just few comments about the thread safety mechanism
Contributor
martinmitrevski
left a comment
martinmitrevski
left a comment
There was a problem hiding this comment.
One of the queues is still serial
ipavlidakis
reviewed
Sep 15, 2023
| func test_log_isThreadSafe() { | ||
| LogConfig.destinationTypes = [ConsoleLogDestination.self] | ||
|
|
||
| DispatchQueue.concurrentPerform(iterations: 100) { _ in |
Contributor
There was a problem hiding this comment.
Without your changes, are those tests failing?
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Related to https://github.com/GetStream/ios-issues-tracking/issues/270
Resolves https://github.com/GetStream/ios-issues-tracking/issues/555
🎯 Goal
Fix crashes related to the Logger not being Thread-safe.
🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist