Skip to content

Conversation

@testableapple
Copy link
Contributor

@testableapple testableapple commented Apr 24, 2024

🔗 Issue Links

Resolve https://github.com/GetStream/ios-issues-tracking/issues/782

🎯 Goal

Allow to pin any message

📝 Summary

  • Replace update with partial update on pinning the message
  • Update DemoApp pinning logic

🎨 Showcase

🧪 Manual Testing Notes

  1. Pin the current user's message

  2. Pin the participant's message

  3. Login as a participant
    => Verify that messages are pinned with correct labels

  4. Unpin the current user's message

  5. Unpin the participant's message

  6. Login as a participant
    => Verify that messages are unpinned

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple added 🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Apr 24, 2024
@testableapple testableapple requested a review from a team as a code owner April 24, 2024 16:38
@Stream-SDK-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 8.34 ms 16.6% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 3.28 ms per s 18.0% 🔼 🟢
Frame rate 79 fps 78.21 fps 1.0% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 2.5 ms 80.0% 🔼 🟢
Duration 2.6 s 0.82 s 68.46% 🔼 🟢
Hitch time ratio 5 ms per s 3.03 ms per s 39.4% 🔼 🟢
Frame rate 76 fps 63.75 fps 16.12% 🔼 🟢
Number of hitches 1.2 0.2 83.33% 🔼 🟢

Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but would be nice to share more details about the db related code we remove.

Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@testableapple testableapple enabled auto-merge (squash) May 1, 2024 09:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 1, 2024

@testableapple testableapple merged commit 9821245 into develop May 1, 2024
@testableapple testableapple deleted the feature/pinning branch May 1, 2024 11:22
@laevandus laevandus mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants