Skip to content

Reduce time spent for type-checking #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laevandus merged 2 commits into from
Oct 9, 2024
Merged

Reduce time spent for type-checking #3453

laevandus merged 2 commits into from
Oct 9, 2024

Conversation

@laevandus
Copy link
Contributor

@laevandus laevandus commented Oct 9, 2024 •
edited
Loading

🔗 Issue Links

Resolves: PBE-6096 (from a public issue)

🎯 Goal

Reduce time spent for type-checking (30-90 ms range)

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@laevandus laevandus added 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🐢 Low Priority An issue that is marked as low priority labels Oct 9, 2024
@laevandus laevandus requested a review from a team as a code owner October 9, 2024 12:30
@github-actions
Copy link

github-actions bot commented Oct 9, 2024

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 9, 2024

SDK Size

title develop branch diff status
StreamChat 6.9 MB 6.9 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 9, 2024

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 3.34 ms 66.6% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 1.31 ms per s 67.25% 🔼 🟢
Frame rate 75 fps 78.02 fps 4.03% 🔼 🟢
Number of hitches 1 0.4 60.0% 🔼 🟢

@laevandus laevandus enabled auto-merge (squash) October 9, 2024 16:23
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 9, 2024

SDK Size

title develop branch diff status
StreamChat 6.9 MB 6.9 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
161 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

@laevandus laevandus merged commit 550c8cb into develop Oct 9, 2024
@laevandus laevandus deleted the slow-type-checking branch October 9, 2024 17:12
@nuno-vieira
Copy link
Member

nuno-vieira commented Oct 14, 2024

Fixes #3428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

Assignees

No one assigned

Labels

🐢 Low Priority An issue that is marked as low priority 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laevandus @Stream-SDK-Bot @nuno-vieira