[CI] Bump Xcode version #3509
[CI] Bump Xcode version #3509
Conversation
SDK Size
|
…where overriding state trigger memory corruption because it contains internal(set), but override is public get and set
SDK Performance
|
| runs-on: macos-14 | ||
| env: | ||
| XCODE_VERSION: "14.0.1" | ||
| XCODE_VERSION: "15.0.1" |
There was a problem hiding this comment.
I was thinking why not 15.4, but I guess because App Store accepts all the Xcode 15 versions
| - name: Run UI Tests (Debug) | ||
| run: bundle exec fastlane test_ui device:"${{ env.IOS_SIMULATOR_DEVICE }}" skip_build:true record:${{ github.event.inputs.snapshots }} | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 120 |
There was a problem hiding this comment.
Lovely, I do have seen this timeout taking my run down
|
Looks good, although I not fully sure why all the snapshot tests were updated. I guess some shade of a color changed fractionally. |
SDK Size
|
|
| import Foundation | ||
| @testable import StreamChat | ||
|
|
||
| public class ChatChannelController_Mock: ChatChannelController { |
There was a problem hiding this comment.
Are we sure this won't break anything? @laevandus We do have customers using this. I wonder if, even with testable import this could break some customers 🤔 We should try to test this branch on SwiftUI to make sure it does not break the tests
laevandus
left a comment
laevandus
left a comment
There was a problem hiding this comment.
Approved, but please add changelog entry about the test tools.
🔗 Issue Links
https://linear.app/stream/issue/IOS-12/
🧪Testing Notes
✅ Cron checks
☑️ Contributor Checklist