Skip to content

Conversation

@nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Oct 22, 2025

🔗 Issue Links

https://linear.app/stream/issue/IOS-1120

🎯 Goal

Fix PollOptionAllVotesView not updated on poll cast events.

📝 Summary

SwiftUI PR from: GetStream/stream-chat-swift#3849

🛠 Implementation

Like UIKit, we now observe poll changes in the all votes list view to update the number of votes.

Note: No tests exist for this view model, so for now, I did not add them as well, since it is a simple fix either way.,

🎨 Showcase

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-10-22.at.12.34.44.mov

🧪 Manual Testing Notes

  • Open Demo App with SwiftUI ENV
  • Open with Darth Maul
  • Open with Leia Organa
  • With Leia organa open "Example" channel
  • Tap on "View Results" from "Hey" poll
  • Tap on "Show All" in the "Two" option
  • From Darth Maul device, open the same channel "Example"
  • Vote the option "Two", and then remove
  • Leia Organa device UI should update correctly

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner October 22, 2025 11:42
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.58 MB 9.58 MB 0 KB 🟢

1 similar comment
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.58 MB 9.58 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

StreamChatSwiftUI XCSize

Object Diff (bytes)
PollOptionAllVotesViewModel.o +993
SearchResultsView.o +920
ChatThreadListItem.o +728
ChatThreadListNavigatableItem.o +716
ChatChannelNavigatableListItem.o +648
Show 36 more objects
Object Diff (bytes)
ChatChannelList.o +648
ChatChannelHeaderViewModifier.o +504
ChatThreadList.o +484
MessageRepliesView.o +456
PinnedMessagesView.o +396
ChatChannelListItem.o +384
MessageContainerView.o +372
ChatChannelListViewModel.o +364
ChatChannelSwipeableListItem.o +280
MessageComposerView.o +252
MessageListView.o +252
ReactionsOverlayView.o +228
VideoAttachmentView.o +216
MessageView.o +188
ComposerHelperViews.o +168
GalleryView.o +156
ReactionsOverlayContainer.o +124
MessageBubble.o +112
QuotedMessageView.o +104
ReactionsView.o +100
ChatChannelView.o +100
ImageAttachmentView.o +92
PollOptionAllVotesView.o +92
VoiceRecordingContainerView.o +60
PollAttachmentView.o +60
MediaAttachmentsView.o +60
MediaAttachmentsViewModel.o +60
GiphyAttachmentView.o +60
DeletedMessageView.o +60
MessageActionsViewModel.o +60
ReactionsHelperViews.o +60
LinkAttachmentView.o +52
MessageListHelperViews.o +52
LinkTextView.o +48
ReactionsBubbleView.o +48
FileAttachmentView.o +48

@github-actions
Copy link

Public Interface

🚀 No changes affecting the public interface.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@nuno-vieira nuno-vieira merged commit 8903e77 into develop Oct 22, 2025
8 of 11 checks passed
@nuno-vieira nuno-vieira deleted the fix/poll-vote-results-list-not-updated branch October 22, 2025 12:17
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants