Skip to content

Conversation

@nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Oct 22, 2025

🔗 Issue Links

Spotted on regression testing.

🎯 Goal

Fix action sheet not showing when discarding Poll creation on iOS 26

🎨 Showcase

Before After
Screen Simulator2

🧪 Manual Testing Notes

  1. Add an option when creating the poll
  2. Tap on "Cancel"
  3. Should see the action sheet

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner October 22, 2025 16:05
.destructive(Text(L10n.Alert.Actions.discardChanges)) {
presentationMode.wrappedValue.dismiss()
},
.default(Text(L10n.Alert.Actions.keepEditing))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change to default instead of cancel. On iOS 26, cancel actions are not shown by default.

@nuno-vieira nuno-vieira merged commit 1a93343 into develop Oct 22, 2025
5 of 6 checks passed
@nuno-vieira nuno-vieira deleted the fix/iOS-26-Poll-discard-changes-action-sheet branch October 22, 2025 16:09
@github-actions
Copy link

Public Interface

🚀 No changes affecting the public interface.

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.58 MB 9.58 MB -1 KB 🚀

@Stream-SDK-Bot
Copy link
Collaborator

StreamChatSwiftUI XCSize

Object Diff (bytes)
CreatePollView.o -418

@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Oct 22, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants