Fix Throttler crash in ChatChannelViewModel.handleMessageAppear()
#1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
approved these changes
Nov 13, 2025
| } | ||
|
|
||
| // Then - Should not crash | ||
| XCTAssert(true) |
Contributor
There was a problem hiding this comment.
Seems like no reason to add, if crashes, then the test will crash and fail.
Member
Author
There was a problem hiding this comment.
Yes I know that, but I think it makes it easier to read the test, it's just for the sake of it. But I can remove it if you want 👍
Collaborator
SDK Size
|
|
Public Interface🚀 No changes affecting the public interface. |
Collaborator
StreamChatSwiftUI XCSize
|
martinmitrevski
approved these changes
Nov 14, 2025
nuno-vieira
deleted the
fix/crash-handleMessageAppear-caused-by-throttler
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-1245
🎯 Goal
Fix Throttler crash in
ChatChannelViewModel.handleMessageAppear().📝 Summary
ChatChannelViewModel.handleMessageAppear()🛠 Implementation
Problem:
The crash was caused by accessing the channel controller at the same time by the main thread and the Throttler's serial queue.
Solution:
We need to change the Throttler's queue to be the main thread as well, just like we are doing in UIKit.
🧪 Manual Testing Notes
N/A. Unit tests have been added to replicate the crash.
☑️ Contributor Checklist
docs-contentrepo