Skip to content

Conversation

@gpunto
Copy link
Collaborator

@gpunto gpunto commented Nov 25, 2025

Goal

AND-892

As the title says, we're moving to the common coverage convention instead of configuring it in here.

Implementation

Remove the custom coverage configuration logic and rely on the plugins

Testing

Coverage should be reported correctly to Sonar

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@gpunto gpunto added the pr:ci CI changes label Nov 25, 2025
@gpunto gpunto requested a review from Copilot November 25, 2025 11:47
Copilot finished reviewing on behalf of gpunto November 25, 2025 11:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates coverage configuration from custom Gradle scripts to convention plugins maintained in the streamConventions dependency. The migration simplifies the build configuration by removing manual setup of Kover and SonarQube plugins.

Key Changes:

  • Removed custom gradle/scripts/sonar.gradle and gradle/scripts/coverage.gradle configuration files
  • Replaced explicit Kover and SonarQube plugin declarations with convention-based approach
  • Configured coverage through the streamProject DSL with includedModules set

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
build.gradle.kts Removed sonar.gradle import and plugin declarations; added coverage configuration block with module specification
stream-android-core/build.gradle.kts Removed explicit Kover and SonarQube plugin applications
gradle/libs.versions.toml Removed Kover and SonarQube plugin version entries; updated streamConventions version to "local-test"
gradle/scripts/sonar.gradle Deleted custom SonarQube configuration script
gradle/scripts/coverage.gradle Deleted custom Kover coverage configuration script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@gpunto gpunto changed the title Configure converage common convention plugins Configure coverage through common convention plugins Nov 25, 2025
Base automatically changed from connection-recovery-handler to develop November 26, 2025 12:43
@sonarqubecloud
Copy link

@gpunto gpunto marked this pull request as ready for review November 26, 2025 13:15
@aleksandar-apostolov aleksandar-apostolov merged commit 19f5a77 into develop Nov 26, 2025
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the plugins.coverage branch November 26, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants