-
Notifications
You must be signed in to change notification settings - Fork 0
Configure coverage through common convention plugins #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
8b75582 to
8880725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates coverage configuration from custom Gradle scripts to convention plugins maintained in the streamConventions dependency. The migration simplifies the build configuration by removing manual setup of Kover and SonarQube plugins.
Key Changes:
- Removed custom
gradle/scripts/sonar.gradleandgradle/scripts/coverage.gradleconfiguration files - Replaced explicit Kover and SonarQube plugin declarations with convention-based approach
- Configured coverage through the
streamProjectDSL withincludedModulesset
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| build.gradle.kts | Removed sonar.gradle import and plugin declarations; added coverage configuration block with module specification |
| stream-android-core/build.gradle.kts | Removed explicit Kover and SonarQube plugin applications |
| gradle/libs.versions.toml | Removed Kover and SonarQube plugin version entries; updated streamConventions version to "local-test" |
| gradle/scripts/sonar.gradle | Deleted custom SonarQube configuration script |
| gradle/scripts/coverage.gradle | Deleted custom Kover coverage configuration script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
8880725 to
2dc2811
Compare
2dc2811 to
bf34083
Compare
|



Goal
AND-892
As the title says, we're moving to the common coverage convention instead of configuring it in here.
Implementation
Remove the custom coverage configuration logic and rely on the plugins
Testing
Coverage should be reported correctly to Sonar
Checklist