Skip to content

Conversation

@aleksandar-apostolov
Copy link
Collaborator

@aleksandar-apostolov aleksandar-apostolov commented Dec 4, 2025

Goal

Lifecycle register should be called on the main thread.

Implementation

Inside start and stop use a utility function runOnMainThread which ensures the Looper.mainLooper() is used.

Testing

Run the sample and ensure that the lifecycle is registered

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@aleksandar-apostolov aleksandar-apostolov merged commit 28a97a7 into develop Dec 9, 2025
5 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the bug-fix-add-main-thread-for-lifecycle branch December 9, 2025 16:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants