Skip to content

Conversation

@gpunto
Copy link
Collaborator

@gpunto gpunto commented Aug 29, 2025

  • Moving sort from feeds to core
  • Introducing type-safe filters (different from what we currently have in feeds)

I'll migrate feeds to this impl after releasing

@gpunto gpunto requested a review from Copilot August 29, 2025 13:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive filtering and sorting system for the Stream Android Core library. The implementation provides type-safe APIs for building filters and sorts that can be used both for local operations and remote API requests.

  • Introduces filter system with operators like equal, greater than, in, query, etc.
  • Adds sorting functionality with configurable directions and composite comparators
  • Provides type-safe field definitions for filters and sorts with remote API mapping

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
FilterToRequestTest.kt Comprehensive test suite validating filter-to-request conversion
FilterOperator.kt Enum defining all supported filter operators with API mapping
SortField.kt Interface for sortable fields with local and remote capabilities
SortDirection.kt Enum for ascending/descending sort directions
SortComparator.kt Comparator classes for local sorting with type erasure support
Sort.kt Main sort configuration class combining field and direction
Filters.kt Utility class and extension functions for building filters
FilterField.kt Base interface for filterable fields
Filter.kt Core filter interfaces and conversion logic
Configuration.kt License URL correction

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aleksandar-apostolov aleksandar-apostolov merged commit 0f9cafa into develop Sep 1, 2025
4 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the typesafe-filters branch September 1, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:new-feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants