Skip to content

fix(llc): fix error while parsing unknown body #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xsahil03x merged 4 commits into from
Dec 3, 2025
Merged

fix(llc): fix error while parsing unknown body #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5afe3d3
fix error while parsing unknown body
renefloor Nov 11, 2025
21bdb04
Also wrap first parsing for apiError with catch
renefloor Nov 11, 2025
24705fd
refactor: Safely parse StreamApiError from DioException
xsahil03x Dec 3, 2025
a8b5381
chore: remove version update
xsahil03x Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/stream_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Upcoming

### 🐛 Bug Fixes

- Fixed `StreamDioException.toClientException()` not handling invalid JSON strings gracefully

## 0.3.0

### 💥 BREAKING CHANGES
Expand Down
18 changes: 10 additions & 8 deletions packages/stream_core/lib/src/api/stream_core_dio_error.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,16 @@ class StreamDioException extends DioException {

extension StreamDioExceptionExtension on DioException {
HttpClientException toClientException() {
final response = this.response;
StreamApiError? apiError;
final data = response?.data;
if (data is Map<String, Object?>) {
apiError = StreamApiError.fromJson(data);
} else if (data is String) {
apiError = StreamApiError.fromJson(jsonDecode(data));
}
final apiErrorResult = runSafelySync(
() => switch (response?.data) {
final Map<String, Object?> data => StreamApiError.fromJson(data),
final String data => StreamApiError.fromJson(jsonDecode(data)),
_ => null,
},
);

final apiError = apiErrorResult.getOrNull();

return HttpClientException(
message: apiError?.message ?? response?.statusMessage ?? message ?? '',
error: apiError ?? this,
Expand Down