-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ui): Added themeable stream icons #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-design-system #35 +/- ##
=====================================================
Coverage ? 45.55%
=====================================================
Files ? 74
Lines ? 1787
Branches ? 0
=====================================================
Hits ? 814
Misses ? 973
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/stream-icons # Conflicts: # packages/stream_core_flutter/lib/src/theme/stream_theme.dart # packages/stream_core_flutter/pubspec.yaml
Submit a pull request
CLA
Description of the pull request
This adds the stream icons as font icons, so we can use the more efficient IconData instead of SVG's.
This also add an option for customers to override (some of) the icons as they are supplied in a theme.
The icons themselves are currently pretty broken, but this should be improved by better svg exports. This PR adds a good structure which we can use going forward. Another PR can fix the actual icons themselves.
Screenshots / Videos
fixed icons:
