Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-design-system #46 +/- ##
=====================================================
Coverage ? 38.82%
=====================================================
Files ? 78
Lines ? 2009
Branches ? 0
=====================================================
Hits ? 780
Misses ? 1229
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/design_system_gallery/lib/config/theme_configuration.dart`:
- Around line 361-364: In _rebuildTheme, the ColorScheme copyWith call currently
passes borderDefault and borderSubtle but omits borderStrong, borderOpacity10,
and borderOpacity25, so changes via their setters never make it into the theme;
update the copyWith invocation (the call in _rebuildTheme that uses
_borderDefault and _borderSubtle) to also pass _borderStrong, _borderOpacity10,
and _borderOpacity25 (using the same internal field names used by the setters)
so all border properties are applied to the resulting theme.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@packages/stream_core_flutter/lib/src/theme/primitives/tokens/dark/stream_tokens.dart`:
- Around line 575-576: Expose the chip tokens and create a chip theme: add
chipBg and chipText as properties on the StreamColors class (stream_colors.dart)
and initialize them from the corresponding tokens defined in stream_tokens.dart
so the color scheme exposes these values; then add a new component theme (e.g.,
StreamChipTheme or StreamChipThemeData) that consumes StreamColors.chipBg and
StreamColors.chipText and maps them to component properties (backgroundColor,
textColor, disabled states, padding/shape as needed) so consumers can access a
ready-made chip theme via the overall theme.
| static const chipBg = Color(0xFF19418D); | ||
| static const chipText = Color(0xFFE3EDFF); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
rg -n "chipBg|chipText" packages --type dartRepository: GetStream/stream-core-flutter
Length of output: 606
🏁 Script executed:
fd -n "color.*scheme\|theme" packages/stream_core_flutter/lib/src/theme --type f | head -20Repository: GetStream/stream-core-flutter
Length of output: 303
🏁 Script executed:
find packages/stream_core_flutter/lib/src/theme -type f -name "*.dart" | head -20Repository: GetStream/stream-core-flutter
Length of output: 1708
🏁 Script executed:
rg -n "chipBg|chipText" packages/stream_core_flutter/lib/src/theme/primitives/stream_colors.dart -A 2 -B 2Repository: GetStream/stream-core-flutter
Length of output: 55
🏁 Script executed:
cat packages/stream_core_flutter/lib/src/theme/primitives/stream_colors.dart | head -100Repository: GetStream/stream-core-flutter
Length of output: 3488
🏁 Script executed:
wc -l packages/stream_core_flutter/lib/src/theme/primitives/stream_colors.dartRepository: GetStream/stream-core-flutter
Length of output: 149
🏁 Script executed:
rg -n "chip" packages/stream_core_flutter/lib/src/theme/primitives/stream_colors.dart -iRepository: GetStream/stream-core-flutter
Length of output: 55
🏁 Script executed:
find packages/stream_core_flutter/lib/src/theme -type f -name "*chip*" -o -name "*Chip*"Repository: GetStream/stream-core-flutter
Length of output: 55
🏁 Script executed:
rg -n "chipBg|chipText" packages --type dart -B 3 -A 3Repository: GetStream/stream-core-flutter
Length of output: 1599
Wire chip tokens through color scheme and create chip theme component.
While chipBg and chipText are correctly defined in both light and dark token files with appropriate inverse colors, they are not exposed in the color scheme (stream_colors.dart) and have no component theme file. These tokens need to be added to StreamColors to make them accessible via the theme, and a chip theme component should be created if these tokens are meant for a specific chip component.
🤖 Prompt for AI Agents
In
`@packages/stream_core_flutter/lib/src/theme/primitives/tokens/dark/stream_tokens.dart`
around lines 575 - 576, Expose the chip tokens and create a chip theme: add
chipBg and chipText as properties on the StreamColors class (stream_colors.dart)
and initialize them from the corresponding tokens defined in stream_tokens.dart
so the color scheme exposes these values; then add a new component theme (e.g.,
StreamChipTheme or StreamChipThemeData) that consumes StreamColors.chipBg and
StreamColors.chipText and maps them to component properties (backgroundColor,
textColor, disabled states, padding/shape as needed) so consumers can access a
ready-made chip theme via the overall theme.
- Add `backgroundDisabled` to `ThemeConfiguration` and customization panel - Refactor color derivation logic for brand, accents, and borders in `_rebuildTheme` - Update Material theme mappings for borders, dividers, and inputs - Add `headingXs` to typography showcase - Replace `Colors` with `StreamColors` for consistency
2 participants
Submit a pull request
CLA
Description of the pull request
Update tokens based on this PR: https://github.com/GetStream/design-system-tokens/pull/15
border subtle now has the same color as surface, so I updated a lot of border colors in the gallery that weren't visible anymore on the surface background color.
Summary by CodeRabbit
New Features
chipBg,chipText, and opacity variants for borders.headingXsandnumericXl.backgroundCoreInverseand expanded chat/badge color tokens.Style