feat(ui): composer attachments#55
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (4.80%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main-design-system #55 +/- ##
=====================================================
Coverage ? 33.13%
=====================================================
Files ? 101
Lines ? 3030
Branches ? 0
=====================================================
Hits ? 1004
Misses ? 2026
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| controller: textEditingController, | ||
| isFloating: false, | ||
| inputTrailing: StreamMessageComposerInputTrailing( | ||
| inputTrailing: StreamBaseMessageComposerInputTrailing( |
There was a problem hiding this comment.
Should we name it StreamCore*?
| @@ -19,10 +26,11 @@ Widget buildStreamMessageComposerPlayground(BuildContext context) { | |||
| child: StreamBaseMessageComposer( | |||
|
|
||
| import '../../../../stream_core_flutter.dart'; | ||
|
|
||
| class MessageComposerAttachmentFile extends StatelessWidget { |
There was a problem hiding this comment.
should we append the attachment, MessageComposerFileAttachment maybe?
packages/stream_core_flutter/lib/src/theme/semantics/stream_color_scheme.dart
Show resolved
Hide resolved
…mposer-attachments # Conflicts: # packages/stream_core_flutter/lib/src/components.dart
Submit a pull request
Linear: FLU-367
CLA
Description of the pull request
New:
Improved:
Most notable changes:
The
StreamMessageComposerInputnow also accepts an alternative for the main body (the input field itself). This is used to replace the input while a voice recording is active.The
StreamMessageComposerInputTrailingis renamed toStreamBaseMessageComposerInputTrailingand no longer automatically changes state based on the text input, as it also needs to change state based on the attachment or other sdk specific rules. It also has more callback options for the mic button.The
MessageComposerAttachmentMediaFilenow also accepts a widget as child if an image provider is not (easily) available.