Separate attachments into a separate library #25
Conversation
Generated by 🚫 Danger |
| import Foundation | ||
|
|
||
| public final class APIError: @unchecked Sendable, Codable, JSONEncodable, Hashable, ReflectiveStringConvertible { | ||
| public final class APIError: @unchecked Sendable, Codable, Hashable, ReflectiveStringConvertible { |
There was a problem hiding this comment.
JSONEncodable is in StreamOpenAPI at the moment. This should be refactored later, for now, I just removed this protocol conformance. APIError seems OpenAPI related but also gets imported into ClientError.
There was a problem hiding this comment.
I think this is going to be a problem for the video SDK. The api error should be json encodable.
…ming clash with chat" This reverts commit 9fd4194.
laevandus
force-pushed
the
restructure-for-chat
branch
from
2699bc2 to
2bfdd08
Compare
laevandus
force-pushed
the
restructure-for-chat
branch
from
2bfdd08 to
ae49c8d
Compare
| import Foundation | ||
|
|
||
| public final class APIError: @unchecked Sendable, Codable, JSONEncodable, Hashable, ReflectiveStringConvertible { | ||
| public final class APIError: @unchecked Sendable, Codable, Hashable, ReflectiveStringConvertible { |
There was a problem hiding this comment.
I think this is going to be a problem for the video SDK. The api error should be json encodable.
| @testable import StreamAttachments | ||
| import Testing | ||
|
|
||
| struct StreamAttachmentsTests { |
There was a problem hiding this comment.
I believe we should have some tests to move here?
There was a problem hiding this comment.
Makes sense to do in a separate PR for reducing the scope of this one. Probably not going to be straight-forward thanks to all the test infrastructure on the chat side.
Package.swift
Outdated
| targets: ["StreamAttachments"] | ||
| ), | ||
| .library( | ||
| name: "StreamOpenAPI", |
There was a problem hiding this comment.
what's the reasoning of splitting up open API stuff? Eventually chat will use it as well.
There was a problem hiding this comment.
I'll think about this one. If I rename new Filter etc types then it would make things simpler. Otherwise there are naming conflicts (chat has Filter which is CoreData based).
There was a problem hiding this comment.
Merged them back to a single library
laevandus
changed the title
|
🔗 Issue Links
Related: IOS-991
🎯 Goal
Separate attachments from core for easier integration in chat
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-contentrepo