Remove fid filtering from ActivityEventHandler
#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes fid-based filtering from ActivityEventHandler in favor of relying solely on activity ID for event filtering. This change addresses reliability issues with feed ID (fid) filtering while maintaining correct event handling for activity-related updates.
Key Changes:
- Removed
FeedIdparameter fromActivityEventHandlerconstructor and all fid-based event filtering logic - Updated event handlers to filter events based only on activity ID
- Removed test cases that verified fid-based filtering behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| stream-feeds-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/handler/ActivityEventHandler.kt | Removed fid parameter from constructor and all fid-based filtering checks in event handlers |
| stream-feeds-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/ActivityImpl.kt | Updated ActivityEventHandler instantiation to remove fid argument |
| stream-feeds-android-client/src/test/kotlin/io/getstream/feeds/android/client/internal/state/event/handler/ActivityEventHandlerTest.kt | Removed fid-based test cases and updated test data to reflect simplified filtering logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...otlin/io/getstream/feeds/android/client/internal/state/event/handler/ActivityEventHandler.kt
Outdated
Show resolved
Hide resolved
...otlin/io/getstream/feeds/android/client/internal/state/event/handler/ActivityEventHandler.kt
Show resolved
Hide resolved
Contributor
SDK Size Comparison 📏
|
gpunto
force-pushed
the
and-904/rm-activiy-handler-fid-filtering
branch
from
eafb462 to
e24d525
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gpunto
force-pushed
the
and-904/rm-activiy-handler-fid-filtering
branch
from
e24d525 to
2a5c4af
Compare
|
VelikovPetar
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Part of the wider AND-904.
This PR removes fid filtering from
ActivityEventHandlersince it's not reliable in all cases and we can just filter based on activity id.Implementation
ActivityEventHandlerand rely on activity idTesting
Updates to an
Activitystate should work as expected, regardless whether we're receiving WS events or not. This is partially testable in the demo for example by opening the comments for an activity in one device and adding/removing comments in that activity in another device.Checklist