Skip to content

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Dec 2, 2025

Goal

AND-816

We're using FeedId in models to represent group+id of a feed, while we were using String in ActivityData.feeds. So we're aligning it.

Implementation

Change from List<String> to List<FeedId> and address the resulting errors.

Testing

No behavior changes.

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@gpunto gpunto added pr:breaking-change Breaking change pr:improvement Improvement labels Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.37 MB 2.37 MB 0.00 MB 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

@gpunto gpunto marked this pull request as ready for review December 2, 2025 13:01
@VelikovPetar VelikovPetar merged commit c945c89 into develop Dec 2, 2025
8 checks passed
@VelikovPetar VelikovPetar deleted the and-816/activitydata-feeds-feedidi branch December 2, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:breaking-change Breaking change pr:improvement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants