Extend own capabilities fetching & caching to other feed own data #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
gpunto
force-pushed
the
and-927/cache-own-all
branch
from
3579f79 to
eb31d19
Compare
gpunto
requested review from
VelikovPetar and
aleksandar-apostolov
and removed request for
VelikovPetar and
aleksandar-apostolov
gpunto
force-pushed
the
and-927/cache-own-all
branch
2 times, most recently
from
876a29f to
980567e
Compare
gpunto
force-pushed
the
and-927/cache-own-all
branch
from
980567e to
cd4e55d
Compare
Collaborator
VelikovPetar
left a comment
VelikovPetar
left a comment
There was a problem hiding this comment.
Left some small naming remarks, otherwise looks pretty good!
...main/kotlin/io/getstream/feeds/android/client/internal/repository/FeedOwnValuesRepository.kt
Outdated
Show resolved
Hide resolved
...client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/ActivityStateImpl.kt
Outdated
Show resolved
Hide resolved
|
VelikovPetar
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
AND-927
In #154 we introduced fetching & caching of feed own capabilities, to remedy the fact that they're empty in
ActivityData.currentFeedon the activity added event. Now the backend allows us to fetch also other own data, i.e. follows & membership, so we're extending the logic to handle those too.Implementation
Basically, wherever we were dealing with capabilities in #154, we now deal with
FeedOwnValuesinstead. The logic is otherwise the same.Testing
You can add some logging to log the own properties of
ActivityData.currentFeed, then add an activity (thus triggering the activity.added event) and verifying that those own properties are enriched correctlyChecklist