Skip to content

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Dec 4, 2025

Goal

Enable StrictMode, check violations and fix them.

Implementation

  • Enable StrictMode in the sample
  • Add suspend + withContext in a couple of functions that are accessing the disk

Testing

Launch the sample and verify that the violation reported for getMimeTypeFromExtension is not logged anymore

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@gpunto gpunto added the pr:improvement Improvement label Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.39 MB 2.39 MB 0.00 MB 🟢

@gpunto gpunto marked this pull request as ready for review December 4, 2025 15:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@VelikovPetar VelikovPetar merged commit 9d23906 into develop Dec 8, 2025
8 checks passed
@VelikovPetar VelikovPetar deleted the enable-strictmode-n-fix branch December 8, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants