Add support for with_activity_data when retrieving reactions #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link512
reviewed
Mar 5, 2019
src/stream-net/Reactions.cs
Outdated
| var urlPath = pagination.GetPath(); | ||
| var request = this._client.BuildJWTAppRequest($"reaction/{urlPath}", HttpMethod.GET); | ||
| filtering.Apply(request); | ||
| //var urlPath = pagination.GetPath(); |
Contributor
Author
There was a problem hiding this comment.
Hello, may I ask when will this make its way to the master branch? I got the latest version from nuget and this is not part of it.
Contributor
There was a problem hiding this comment.
i will merge it and deploy it now
Link512
suggested changes
Mar 5, 2019
Contributor
Link512
left a comment
Link512
left a comment
There was a problem hiding this comment.
left a small comment. Some unit tests would also be nice to have in IntegrationTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.