feat: small enhancement #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
reviewed
Jan 13, 2022
peterdeme
force-pushed
the
small_enhancement
branch
2 times, most recently
from
e916fc4 to
001f132
Compare
ferhatelmas
reviewed
Jan 13, 2022
peterdeme
force-pushed
the
small_enhancement
branch
3 times, most recently
from
b6934d9 to
5d5d39b
Compare
peterdeme
force-pushed
the
small_enhancement
branch
from
5d5d39b to
e8acf9f
Compare
ferhatelmas
approved these changes
Jan 13, 2022
Contributor
|
can we push commits separately, instead of push force ? It makes harder to see what is changed on ongoing reviews |
Contributor
Author
|
@ferhatelmas sure. I've been doing amended commits for 4 years and I'm so used to it haha. But I'll try! |
Contributor
Thanks! My concern was related to conventional commits if our pipeline can work with multiple commits or not |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.